Compatiblity with Symfony 4.3 by dunglas · Pull Request #2784 · api-platform/core

dunglas · 2019-05-10T10:54:17Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

dunglas · 2019-06-16T06:38:11Z

Thank you very much @soyuka and @alanpoulain for the help!

teohhanhui · 2019-06-18T08:34:34Z

 /**
 * Generic item normalizer.
 *
- * @final


I don't think this is right. The GraphQL ItemNormalizer should stop extending this class instead, but instead extend AbstractItemNormalizer.

teohhanhui · 2019-06-18T08:36:26Z


        $loader->load(__DIR__."/config/config_{$this->getEnvironment()}.yml");

+        $alg = class_exists(SodiumPasswordEncoder::class) && SodiumPasswordEncoder::isSupported() ? 'auto' : 'bcrypt';


Uhh... Symfony really screwed this one up. :x

It's not bcrypt if sodium isn't supported but the native encoder. I do not know if it's important here.
The bcrypt encoder is now deprecated

It's only for old versions so I think we don't care (this code will go be thrown away at some point).

teohhanhui · 2019-06-18T08:37:40Z

It seems like this is not addressed? #2856

soyuka · 2019-06-18T13:05:19Z

I'm not sure to understand how #2856 is an issue here...

teohhanhui · 2019-06-18T15:52:24Z

@soyuka No, it's not an issue here. Just that I'd consider #2856 essential for Symfony 4.3 compatibility. Because it's not doing the right thing now.

soyuka · 2019-06-21T07:55:48Z

True although I'm not sure to get what we need to do on our side.

bastnic · 2019-06-26T20:31:46Z

Why only master and not 2.4 branch ? My tests are full of 59403x: Method "ApiPlatform\Core\Serializer\ItemNormalizer::createChildContext()" will have a third "?string $format" argument in version 5.0; not defining it is deprecated since Symfony 4.3.

dunglas · 2019-06-26T20:40:24Z

Because Messenger. Messenger 4.3 introduces some BC breaks, that in cascade force us to add some BC breaks too. Also, to use Messenger 4.3 we had to bump the version of several other Symfony components. We then decided that it wasn't a good idea to introduce such changes in a patch release.
Anyway, we're working hard on finishing 2.5, a beta should be available soon.

teohhanhui · 2019-06-26T20:44:27Z

We could certainly backport the other changes that are not related to Symfony Messenger.

dunglas · 2019-06-26T20:47:16Z

Maybe some of them yes! Feel free to open a PR!

* Compatiblity with Symfony 4.3 * Fix all broken unit tests * Fix some deprecations * Remove @Final from ItemNormalizer * Fix Behat tests * Use composition for the Exception Listener * Fix default firewall logout_on_user_change deprecation * Make sure that sodium is supported * Fix composer and tests * Fix PHPStan config and CS * Remove deprecated option * Fix MongoDB * Fix rebase

dunglas changed the base branch from master to 2.4 May 10, 2019 10:54

dunglas changed the base branch from 2.4 to master May 10, 2019 10:54

dunglas force-pushed the sf4.3-compat branch from b3ee949 to 6127157 Compare May 15, 2019 20:45

alanpoulain force-pushed the sf4.3-compat branch 4 times, most recently from 1aa8822 to 58ace00 Compare May 31, 2019 16:07

alanpoulain marked this pull request as ready for review May 31, 2019 16:07

alanpoulain added the [WIP] Work In Progress label May 31, 2019

alanpoulain force-pushed the sf4.3-compat branch 10 times, most recently from 4b2af33 to 5f58782 Compare June 1, 2019 18:01

alanpoulain mentioned this pull request Jun 3, 2019

Deprecated code since Symfony 4.3. #2835

Closed

soyuka force-pushed the sf4.3-compat branch 2 times, most recently from f140dac to 04d6f0b Compare June 4, 2019 15:52

dunglas mentioned this pull request Jun 4, 2019

Fix build with Symfony 4.3 #2841

Merged

dunglas mentioned this pull request Jun 12, 2019

Cannot install symfony/messenger api-platform/api-platform#1169

Closed

soyuka force-pushed the sf4.3-compat branch 2 times, most recently from 315509b to ccfafca Compare June 14, 2019 14:55

dunglas commented Jun 15, 2019

View reviewed changes

Comment thread features/jsonld/context.feature

dunglas force-pushed the sf4.3-compat branch from 3440da5 to 6d16731 Compare June 15, 2019 11:12

dunglas added 2 commits June 15, 2019 15:15

Compatiblity with Symfony 4.3

fa057ce

Fix all broken unit tests

9f65b2b

dunglas and others added 10 commits June 15, 2019 15:15

Fix some deprecations

6e236dd

Remove @Final from ItemNormalizer

d93b4e2

Fix Behat tests

f7a4320

Use composition for the Exception Listener

7b99246

Fix default firewall logout_on_user_change deprecation

795192b

Make sure that sodium is supported

17d17d3

Fix composer and tests

2260d05

Fix PHPStan config and CS

d902ea8

Remove deprecated option

830d2fc

Fix MongoDB

22e953c

dunglas force-pushed the sf4.3-compat branch from 6d16731 to 22e953c Compare June 15, 2019 13:16

Fix rebase

9f3d6bd

dunglas merged commit 6e2c268 into api-platform:master Jun 16, 2019

dunglas deleted the sf4.3-compat branch June 16, 2019 06:37

teohhanhui reviewed Jun 18, 2019

View reviewed changes

Comment thread composer.json

teohhanhui reviewed Jun 18, 2019

View reviewed changes

teohhanhui reviewed Jul 1, 2019

View reviewed changes

Comment thread src/Bridge/Symfony/Messenger/DataPersister.php

teohhanhui mentioned this pull request Jul 10, 2019

Fix compatibility with Symfony 4.3 #2925

Merged

teohhanhui reviewed Jul 10, 2019

View reviewed changes

Comment thread features/graphql/mutation.feature


		$loader->load(__DIR__."/config/config_{$this->getEnvironment()}.yml");

		$alg = class_exists(SodiumPasswordEncoder::class) && SodiumPasswordEncoder::isSupported() ? 'auto' : 'bcrypt';

Uh oh!

Uh oh!

Conversation

dunglas commented May 10, 2019 • edited by alanpoulain Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dunglas commented Jun 16, 2019

Uh oh!

Uh oh!

teohhanhui Jun 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teohhanhui Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

maxhelias Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

dunglas Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

teohhanhui commented Jun 18, 2019

Uh oh!

soyuka commented Jun 18, 2019

Uh oh!

teohhanhui commented Jun 18, 2019

Uh oh!

soyuka commented Jun 21, 2019

Uh oh!

bastnic commented Jun 26, 2019

Uh oh!

dunglas commented Jun 26, 2019

Uh oh!

teohhanhui commented Jun 26, 2019

Uh oh!

dunglas commented Jun 26, 2019

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dunglas commented May 10, 2019 •

edited by alanpoulain

Loading

teohhanhui Jun 18, 2019 •

edited

Loading